Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conv1d #506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

conv1d #506

wants to merge 2 commits into from

Conversation

malmaud
Copy link
Owner

@malmaud malmaud commented May 17, 2019

Rebased version of #480

@malmaud malmaud requested a review from oxinabox as a code owner May 17, 2019 18:03
@malmaud malmaud mentioned this pull request May 17, 2019
@@ -13,3 +13,4 @@ MacroTools 0.3.6
AutoHashEquals 0.1.0
MLDatasets 0.3.0
SpecialFunctions 0.7.0
Optim 0.17.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now delete the REQUIRE file

@@ -135,6 +135,7 @@ with_tape


using Distributed
using Optim
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in This PR?

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #506 into master will decrease coverage by 1.49%.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #506     +/-   ##
========================================
- Coverage    54.7%   53.2%   -1.5%     
========================================
  Files          86      83      -3     
  Lines        2702    2654     -48     
========================================
- Hits         1478    1412     -66     
- Misses       1224    1242     +18
Impacted Files Coverage Δ
src/TensorFlow.jl 81.25% <ø> (-7.64%) ⬇️
src/ops/nn.jl 55.55% <81.81%> (+3.05%) ⬆️
src/protobufs/types_pb.jl 0% <0%> (-100%) ⬇️
src/protobufs/saver_pb.jl 0% <0%> (-50%) ⬇️
src/protobufs/rewriter_config_pb.jl 11.11% <0%> (-33.34%) ⬇️
src/io/readers.jl 0% <0%> (-25%) ⬇️
src/ops/logical.jl 0% <0%> (-20%) ⬇️
src/protobufs/config_pb.jl 29.62% <0%> (-11.12%) ⬇️
src/py.jl 0% <0%> (-10.64%) ⬇️
src/protobufs/event_pb.jl 10.52% <0%> (-10.53%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32dd975...485d3ad. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants