Skip to content

Commit

Permalink
Call signal handlers with release events even if signal is persistent.
Browse files Browse the repository at this point in the history
  • Loading branch information
malloch committed Sep 3, 2024
1 parent 9a9ba0d commit a0da74b
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -521,10 +521,9 @@ int mpr_sig_osc_handler(const char *path, const char *types, lo_arg **argv, int
mpr_dev_GID_decref(dev, sig->group, remote_id_map);
}
}
// TODO: if user-code has registered callback for release events we should proceed even
// if the signal is non-ephemeral. Perhaps they want to do somethinng when released upstrm
// Conceptually this matches setting the "released" bitflag above
RETURN_ARG_UNLESS(sig->ephemeral && (!map || mpr_map_get_use_inst((mpr_map)map)), 0);
/* if user-code has registered callback for release events we will proceed even if the
* signal is non-ephemeral. Conceptually this matches setting the "released" bitflag. */
RETURN_ARG_UNLESS(!map || mpr_map_get_use_inst((mpr_map)map), 0);

/* Try to release instance, but do not call process_maps() here, since we don't
* know if the local signal instance will actually be released. */
Expand Down

0 comments on commit a0da74b

Please sign in to comment.