Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Feature/add id prop #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/add id prop #164

wants to merge 2 commits into from

Conversation

desmukh
Copy link

@desmukh desmukh commented May 22, 2020

Allow id attribute to be passed as a prop. Solution to issue #86

davidjb added a commit to davidjb/react-scrollspy that referenced this pull request May 28, 2020
@davidjb
Pass through props to the componentTag
9b2262d 
Solves makotot#86 and is a more generic solution than makotot#164, working for *any* prop.
@davidjb davidjb mentioned this pull request May 28, 2020
Open
@davidjb
Copy link
Contributor

davidjb commented May 28, 2020

Hi @desmukh, I created #168 as a way of passing all props through, including id.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desmukh @davidjb