Skip to content

Commit

Permalink
Merge pull request #221 from makinosp/feature/link-to-account-settings
Browse files Browse the repository at this point in the history
Feature/link to account settings
  • Loading branch information
makinosp authored Nov 22, 2024
2 parents fb8be1c + 493e29c commit f8166a2
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Harmonie.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0.1;
MARKETING_VERSION = 1.0.2;
PRODUCT_BUNDLE_IDENTIFIER = jp.mknn.harmonie;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = YES;
Expand Down Expand Up @@ -510,7 +510,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0.1;
MARKETING_VERSION = 1.0.2;
PRODUCT_BUNDLE_IDENTIFIER = jp.mknn.harmonie;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = YES;
Expand Down
3 changes: 3 additions & 0 deletions harmonie/Components/IconSet.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//

enum IconSet {
static var account: some Iconizable {
Icon("person.text.rectangle")
}
static var at: some Iconizable {
Icon("at")
}
Expand Down
16 changes: 16 additions & 0 deletions harmonie/Localization/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,22 @@
}
}
},
"Account Settings" : {
"localizations" : {
"ja" : {
"stringUnit" : {
"state" : "translated",
"value" : "アカウント設定"
}
},
"zh-Hans" : {
"stringUnit" : {
"state" : "translated",
"value" : "账号设置"
}
}
}
},
"Activity" : {
"localizations" : {
"ja" : {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ extension SettingsView {
Button("Edit", systemImage: IconSet.edit.systemName) {
isPresentedForm.toggle()
}
if let url = URL(string: "https://vrchat.com/home/profile") {
ExternalLink(
title: String(localized: "Account Settings"),
url: url,
systemImage: IconSet.account.systemName
)
}
}
.textCase(nil)
}
Expand Down

0 comments on commit f8166a2

Please sign in to comment.