Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character-level rotate support #31

Closed
wants to merge 2 commits into from

Conversation

hanfeisun
Copy link

A possible solution for this issue:
#30

Demo can be previewed at:
http://hanfeisun.github.io/Leaflet.TextPath/

@leplatrem
Copy link
Collaborator

This is great ! Thank you !

Would you mind adding a mention in the readme to expose the feature ?

@leplatrem
Copy link
Collaborator

Thanks !

@fredericbonifas from my side, it looks ok to merge

@leplatrem
Copy link
Collaborator

I hadn't seen that @kirkau had implemented something similar. Maybe we can merge both into one rotate option.

The solution is different though :)

@fredericbonifas
Copy link
Collaborator

Thanks for this PR. I don't know yet how to name this option as a rotate option is already available. For now, you proposal can be implemented using the attributes option:

attributes: {
    "style": "writing-mode: tb-rl; glyph-orientation-vertical: 180;"
}

@hanfeisun
Copy link
Author

@fredericbonifas I agree it can be implemented in the attribute, but that may look a bit intricate. There is no rotate option currently but only an option called orientation, which is "word-level rotate" instead of "character-level rotate"..

@mabhub
Copy link
Member

mabhub commented Mar 1, 2018

Rotation of text is now possible through orientation option.

Please share any additional comments you may have.

@mabhub mabhub closed this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants