Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 delegator migration release #965

Merged
merged 14 commits into from
Nov 21, 2024
Merged

v2 delegator migration release #965

merged 14 commits into from
Nov 21, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Nov 20, 2024

Link to Shortcut ticket:

What does this PR do?

Steps for testing:

Screenshots (if relevant):

Any additional helpful information?:

Add a GIF:

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:45pm

Copy link

what-the-diff bot commented Nov 20, 2024

PR Summary

  • Renamed a specific field in contract fetching: The isRenewed flag in the fetchDelegatedTo.ts module has been renamed to isRenewedToV2. This more precisely indicates that the renewal pertains to the second version of the delegate contract.
  • Adjusted type definitions: The field name change from the previous point was propagated to the type definitions in delegate.d.ts. This enhances the clarity of the contract's status.
  • Updated display conditions for migration banner: The logic in the MigrationBanner.tsx file that decides when to show a migration banner has been updated. Parts of the conditions to display it have been uncommented to incorporate the isDelegatedToV1Contract status.
  • Streamlined variables in migration status usage: Unnecessary variables in the useMigrationStatus.tsx file were removed. This cleanup includes the removal of isDelegateContractExpiring and isDelegatedToExpiredContract, making the overall codebase more focused and manageable.
  • Implemented adjusted validation reference: The computation process of isDelegatedToV1Contract has been altered. Now it references the new isRenewedToV2 property in place of the outdated isRenewed, aligning validation to the correct delegated contract status.

@tyler17 tyler17 merged commit 2349f08 into master Nov 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants