Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master -> develop #964

Merged
merged 1 commit into from
Nov 20, 2024
Merged

master -> develop #964

merged 1 commit into from
Nov 20, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Nov 20, 2024


Link to Shortcut ticket:

What does this PR do?

Steps for testing:

Screenshots (if relevant):

Any additional helpful information?:

Add a GIF:

* Check v1 delegate first

* Add additional delegate links (#957)

* Add byteron link

* PBG and UPMaker

* Update Tenderly VDF v2 contract and use Tenderly SDK

* Add test delegate migration

* Add vigilant v2 contract

* Use more consistent names (#960)

---------

Co-authored-by: Adam Goth <[email protected]>
Co-authored-by: Hector Rodriguez Fornies <[email protected]>
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:32pm

Copy link

what-the-diff bot commented Nov 20, 2024

PR Summary

  • New JSON file addition: A new file voteDelegateFactoryOld.json was added which carries original or old information about vote delegate factory contract. This can serve as a helpful backup.
  • Address update for vote delegate factory: The location information which is the 'address' for voteDelegateFactory in the file eth-sdk.config.ts was updated to a new one. An old address was also retained and labelled as voteDelegateFactoryOld.
  • Enhanced logic for delegate address fetching: The code in getDelegateContractAddress.ts has been improved. Now it verifies new as well as old delegate addresses and provides the suitable address if it is valid.
  • Addition to migration mappings: Extra mappings have been added in delegateAddressLinks.ts for more delegate addresses. Clearer comments have also been included to guide readers better through the code.
  • New mappings for polling tags: The file poll-tags-mapping.json now houses more mappings for different poll IDs, allowing more comprehensive and detailed categorization.
  • Change in contract SDK utilization: The way SDKs (Software Development Kits) are imported and utilized in getContracts.ts and getReadOnlyContracts.ts has been changed. Now getTenderlySdk is used rather than getMainnetSdk for the Tenderly network. This allows for optimized contract handling in the specific network.

@tyler17 tyler17 merged commit c6ce69e into develop Nov 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants