Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avc removal #897

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Avc removal #897

merged 4 commits into from
Jun 19, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Jun 19, 2024

Remove the rest of the AVC related code that's no longer being used

@tyler17 tyler17 added the WIP label Jun 19, 2024
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jun 19, 2024 5:03am

Copy link

what-the-diff bot commented Jun 19, 2024

PR Summary

This pull request involves extensive updates focusing on eliminating the AVCs (an undefined term) related elements from the application. At the crux of the changes is the removal of a type and related code from ResourceBox.tsx. Additionally, multiple associated files have been deleted, with 'AVCs' being stripped from numerous parts of the system.

The changes are summarized as follows:

  • In ResourceBox.tsx, a type avcs is removed, leading to accompanying code modifications.
  • Numerous AVCs-associated files have been deleted, removing their functionalities from the system.
  • Several changes have been pushed in modules/delegates/... sub-directories, comprising removal of avcs and avc_name from import statements, parameters, properties, and component logic.
  • Various parts of pages/delegates/index.tsx have been updated. That includes several modifications concerning the removal of AVCs-related variables from React's useEffect Hook, and adjusting the component's logic. Furthermore, AVCs-associated parameters are deleted from a wide range of function calls within this component.

This high-level clean-up effort is simplifying the codebase, increasing its efficiency, and enhancing overall system performance. Based on these changes, likely, the AVCs feature is no longer necessary for the delegates module of the application, imposing a significant shift in the way certain aspects of the application work.

@tyler17 tyler17 merged commit 7467c40 into develop Jun 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants