Skip to content

[WEB-6840] feat: skip role & use-case steps for self-hosted instances#8890

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
feat/skip-onboarding-survey-self-hosted
Apr 13, 2026
Merged

[WEB-6840] feat: skip role & use-case steps for self-hosted instances#8890
sriramveeraghanta merged 1 commit intopreviewfrom
feat/skip-onboarding-survey-self-hosted

Conversation

@anmolsinghbhatia
Copy link
Copy Markdown
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Apr 13, 2026

Description

This PR updates the self-hosted onboarding flow by skipping the role and use-case steps.

Type of Change

  • Improvement

Media

Preview
preview

Summary by CodeRabbit

  • Improvements
    • Refined onboarding flow with improved step sequencing and navigation based on your instance configuration.
    • Enhanced progress tracking for a more streamlined setup experience.
    • Optimized workflow progression during initial configuration for better user guidance.

@anmolsinghbhatia anmolsinghbhatia self-assigned this Apr 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

📝 Walkthrough

Walkthrough

The onboarding flow is modified to conditionally adjust steps and transitions based on whether an instance is self-managed. Step ordering is now dynamically constructed, and navigation paths change according to the isSelfManaged configuration status retrieved via useInstance.

Changes

Cohort / File(s) Summary
Conditional Self-Managed Onboarding Flow
apps/web/core/components/onboarding/header.tsx, apps/web/core/components/onboarding/root.tsx
Both components now read instanceConfig via useInstance() hook and derive isSelfManaged. Header dynamically constructs step order to conditionally include/exclude ROLE_SETUP and USE_CASE_SETUP, updating step numbering accordingly. Root modifies profile setup transitions to skip ROLE_SETUP for self-managed instances and either finish onboarding or advance to workspace creation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hops the onboarding hare, rearranging with care,
Self-managed or cloud-bound, a branching affair,
Steps dance and reorder, conditions decide,
Through instance config flows, no stone left untried!
Workspaces and roles in a neat new array,
Progress now bends to each instance's way. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the main purpose and includes type of change, but omits required sections: Test Scenarios and References are missing or incomplete. Add a Test Scenarios section describing how the changes were validated, and include a References section linking to issue WEB-6840 or related issues.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: skipping role and use-case steps for self-hosted instances, which matches the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/skip-onboarding-survey-self-hosted

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@makeplane
Copy link
Copy Markdown

makeplane bot commented Apr 13, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review April 13, 2026 12:47
Copilot AI review requested due to automatic review settings April 13, 2026 12:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the web onboarding flow to streamline self-hosted (self-managed) instances by skipping the role and use-case steps, while keeping the progress/header behavior consistent with the revised step sequence.

Changes:

  • Skip ROLE_SETUP and USE_CASE_SETUP after PROFILE_SETUP when the instance is self-managed.
  • Update the onboarding header “back” navigation and progress step calculation to reflect the self-managed step sequence.
  • Adjust progress step ordering to include INVITE_MEMBERS when it’s actually shown (avoids progress miscount when the invite step is reached).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/web/core/components/onboarding/root.tsx Adds self-managed branching to skip role/use-case steps and route directly to workspace/onboarding completion.
apps/web/core/components/onboarding/header.tsx Makes progress/back-navigation aware of self-managed step order and dynamically derives total steps from step order.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/web/core/components/onboarding/root.tsx (1)

104-104: Consider using workspacesList.length in the dependency array.

workspacesList is created via Object.values(workspaces ?? {}) on line 33, producing a new array reference each render. This causes handleStepChange to be recreated unnecessarily. Since the callback only checks workspacesList.length, use the length directly:

♻️ Suggested improvement
-    [stepChange, finishOnboarding, workspacesList, isSelfManaged]
+    [stepChange, finishOnboarding, workspacesList.length, isSelfManaged]
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/web/core/components/onboarding/root.tsx` at line 104, The dependency
array for the memoized callback (handleStepChange) currently includes
workspacesList (created from Object.values(workspaces ?? {})), which produces a
new array each render; change the dependency to depend on workspacesList.length
(or compute a stable workspaceCount from workspaces and use that) instead of the
full array so handleStepChange isn't recreated unnecessarily; update the
dependency array used where stepChange, finishOnboarding, workspacesList,
isSelfManaged are listed to replace workspacesList with workspacesList.length
(or workspaceCount) and keep references to stepChange, finishOnboarding, and
isSelfManaged unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/web/core/components/onboarding/root.tsx`:
- Line 104: The dependency array for the memoized callback (handleStepChange)
currently includes workspacesList (created from Object.values(workspaces ??
{})), which produces a new array each render; change the dependency to depend on
workspacesList.length (or compute a stable workspaceCount from workspaces and
use that) instead of the full array so handleStepChange isn't recreated
unnecessarily; update the dependency array used where stepChange,
finishOnboarding, workspacesList, isSelfManaged are listed to replace
workspacesList with workspacesList.length (or workspaceCount) and keep
references to stepChange, finishOnboarding, and isSelfManaged unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9a627a99-1cc4-47eb-b9c9-45e873d8c1d6

📥 Commits

Reviewing files that changed from the base of the PR and between 39325d2 and bf5ae79.

📒 Files selected for processing (2)
  • apps/web/core/components/onboarding/header.tsx
  • apps/web/core/components/onboarding/root.tsx

@sriramveeraghanta sriramveeraghanta merged commit db3c8f2 into preview Apr 13, 2026
18 checks passed
@sriramveeraghanta sriramveeraghanta deleted the feat/skip-onboarding-survey-self-hosted branch April 13, 2026 12:54
@makeplane
Copy link
Copy Markdown

makeplane bot commented Apr 13, 2026

⚠️ State transition attempt blocked by project workflow settings for the following Work Item(s)

This comment was auto-generated by Plane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants