Skip to content

[GIT-40]fix: apply sub-issue display filter when adding work items #8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vamsikrishnamathala wants to merge 1 commit into
base: preview
Choose a base branch
from
+5 −0
Draft

[GIT-40]fix: apply sub-issue display filter when adding work items #8534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/web/core/store/issue/helpers/base-issues.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,6 +1198,9 @@ export abstract class BaseIssuesStore implements IBaseIssuesStore {
const issueId = issue?.id ?? issueBeforeUpdate?.id;
if (!issueId) return;

// Get display filters to check if 'Show sub Work items' is enabled - Donot add Work item to main list if disabled.
const isShowWorkItemsEnabled = this.issueFilterStore.issueFilters?.displayFilters?.sub_issue ?? false;

// get issueUpdates from another method by passing down the three arguments
// issueUpdates is nothing but an array of objects that contain the path of the issueId list that need updating and also the action that needs to be performed at the path
const issueUpdates = this.getUpdateDetails(issue, issueBeforeUpdate, action);
Expand All @@ -1207,6 +1210,8 @@ export abstract class BaseIssuesStore implements IBaseIssuesStore {
for (const issueUpdate of issueUpdates) {
//if update is add, add it at a particular path
if (issueUpdate.action === EIssueGroupedAction.ADD) {
const isSubIssue = issue?.parent_id;
if (isSubIssue && !isShowWorkItemsEnabled) continue;
// add issue Id at the path
update(this, ["groupedIssueIds", ...issueUpdate.path], (issueIds: string[] = []) =>
this.issuesSortWithOrderBy(uniq(concat(issueIds, issueId)), this.orderBy)
Expand Down
Loading