Fully translated in Georgian #7837
Conversation
|
|
WalkthroughAdds Georgian (ka-ge) locale resources: accessibility ARIA labels, comprehensive core UI/auth translations, and an empty editor.json scaffold. No application logic or APIs changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds complete Georgian language support by creating localization files for the ka-ge locale. The changes include translation of UI components, authentication flows, accessibility labels, and editor elements to Georgian.
Key changes:
- Added comprehensive Georgian translations for core UI elements (~170 translations)
- Implemented authentication flow translations including sign-up, sign-in, and password management
- Added accessibility labels for screen readers and assistive technology support
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/i18n/src/locales/ka-ge/editor.json | Creates empty editor translations file |
| packages/i18n/src/locales/ka-ge/core.json | Adds core UI translations including sidebar, authentication flows, and common elements |
| packages/i18n/src/locales/ka-ge/accessibility.json | Provides Georgian translations for accessibility labels and ARIA descriptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -0,0 +1 @@ | |||
| {} No newline at end of file | |||
There was a problem hiding this comment.
The editor.json file contains only an empty object. This creates an incomplete localization that may cause fallback issues. Consider either populating it with editor-specific translations or removing the file until translations are available.
| {} |
Copilot uses AI. Check for mistakes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/i18n/src/locales/ka-ge/accessibility.json (1)
24-24: Double‑check “edition_badge” label intent.“გადახდილი გეგმის ფანჯრის გახსნა” sounds like opening a window, while “badge” is a status/label. Please confirm the UX intent against the English source to avoid misleading screen‑reader output.
packages/i18n/src/locales/ka-ge/core.json (2)
141-141: Avoid leaking server config details in end‑user errors.“Smtp_not_enabled” exposes internal state. Consider a neutral message while logging the diagnostic server‑side.
Suggested copy:
- "smtp_not_enabled": "როგორც ვხედავთ, თქვენს სერვერზე SMTP არ არის ჩართული, ამიტომ პაროლის აღდგენის ბმულს ვერ გამოგიგზავნით" + "smtp_not_enabled": "ამ სერვერზე ელფოსტა ამჟამად მიუწვდომელია, ამიტომ პაროლის აღდგენის ბმულს ვერ გავგზავნით."
10-11: Minor terminology check for “views”.Confirm “ხილვები” matches existing Georgian UX terminology for this section in Plane. If the product uses a different term elsewhere, align for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/i18n/src/locales/ka-ge/accessibility.json(1 hunks)packages/i18n/src/locales/ka-ge/core.json(1 hunks)packages/i18n/src/locales/ka-ge/editor.json(1 hunks)
🔇 Additional comments (3)
packages/i18n/src/locales/ka-ge/accessibility.json (1)
1-34: Confirm locale casing aligns with project convention (BCP‑47).Paths use ka-ge; many i18n setups expect region uppercase (ka-GE). Ensure the loader registers the exact variant you’re adding, or add an alias/mapping.
packages/i18n/src/locales/ka-ge/core.json (1)
88-89: Validate placeholder usage in resend text.Ensure the runtime formatter expects {seconds} exactly (no “%s” or “{{}}”) and that countdown logic supplies an integer.
packages/i18n/src/locales/ka-ge/editor.json (1)
1-1: JSON & key parity OK — confirm locale registration and fallback.
- packages/i18n/src/locales/ka-ge/{core.json,accessibility.json,editor.json} validated: core/accessibility match en (no missing/extra); editor.json is empty ({}) and valid.
- Action: verify the i18n loader actually registers/loads "ka-ge" (e.g. packages/i18n/src/locales/index.ts or the loader entrypoint) so the editor UI falls back to the base locale for missing editor keys.
| "errors": { | ||
| "match": "პაროლები არ ემთხვევა", | ||
| "empty": "გთხოვთ შეიყვანოთ პაროლი", | ||
| "length": "პაროლის სიგრძე უნდა იყოს 8 სიმბოლოზე მეტი", |
There was a problem hiding this comment.
Password length copy likely incorrect (“>8” vs “≥8”).
Text says “8 სიმბოლოზე მეტი” (strictly more than 8). Typically policies mean “at least 8”. Adjust to avoid user confusion and unintended lockouts.
Apply this change:
- "length": "პაროლის სიგრძე უნდა იყოს 8 სიმბოლოზე მეტი",
+ "length": "პაროლის სიგრძე უნდა იყოს მინიმუმ 8 სიმბოლო",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "length": "პაროლის სიგრძე უნდა იყოს 8 სიმბოლოზე მეტი", | |
| "length": "პაროლის სიგრძე უნდა იყოს მინიმუმ 8 სიმბოლო", |
🤖 Prompt for AI Agents
In packages/i18n/src/locales/ka-ge/core.json around line 56, the Georgian copy
reads "პაროლის სიგრძე უნდა იყოს 8 სიმბოლოზე მეტი" (strictly greater than 8) but
should indicate "at least 8"; replace that string with a phrasing conveying
"minimum 8" such as "პაროლის სიგრძე უნდა იყოს მინიმუმ 8 სიმბოლო" so the
requirement matches the intended ≥8 policy.
Description
Added full Georgian language support to the project.
Type of Change
Screenshots and Media (if applicable)
Add screenshots or recordings if needed to demonstrate Georgian UI rendering.
Test Scenarios
References
No related issues.
Summary by CodeRabbit