Skip to content

Conversation

@DagonWat
Copy link

@DagonWat DagonWat commented Dec 18, 2025

Motivation

  • We need to keep SDKs Readme's in same format and standard

Changes

  • Update README.md

@DagonWat DagonWat changed the base branch from main to add-projects-api December 18, 2025 10:49
@DagonWat DagonWat requested review from IgorDobryn and i7an December 18, 2025 10:49
Email API:
- Full email sending – [`full.rb`](examples/full.rb)

### Content-Transfer-Encoding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you simply removed a chunk of documentation. Maybe it should be moved somewhere instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, my idea was that if other libs are not utilizing these points, it means these points were suppressed on its way to our SDK documentation formats. These 2 paragraphs 'Content-Transfer-Encoding' and 'Multiple Mailtrap Clients' are not existing in other major libraries while they absolutely make same sense to be there.

Do you vote for me to keep them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah lets keep them. Those chapters were added to address customer requests. I dont see the value in removing the documentation. If your goal is to unify the structure, please do that and keep the existing docs.

@i7an
Copy link
Contributor

i7an commented Dec 22, 2025

The PR description is probably not up to date.

@mailtrap mailtrap deleted a comment from coderabbitai bot Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants