Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed MAX_CHUNK_SIZE to const 4MB and removed lazy_static and dereferencing #400

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Changed MAX_CHUNK_SIZE to const 4MB and removed lazy_static and dereferencing #400

wants to merge 4 commits into from

Conversation

vphongph
Copy link

@vphongph vphongph commented Feb 20, 2025 •
edited
Loading

Following the update of Autonomi repo: maidsafe/autonomi#2765

Did the changes accordingly

  • MAX_CHUNK_SIZE, from lazy static -> const (kept the 4MB)
  • Removed all the logic behind the lazy static, it was not relevant
  • Removed the dereferencing for calling the const

EDIT:

  • sorry for the commit itself, failed to change my name from previous job
  • forgot to create branch, it's a pull request from my fork main

@vphongph vphongph requested a review from a team as a code owner February 20, 2025 07:35
grumbach
grumbach approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@grumbach grumbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grumbach grumbach grumbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vphongph @grumbach @vp-kaertech