Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): shall use get_closest_local_peers instead of find_closest #2823

Open
wants to merge 1 commit into
base: rc-2025.1.2-hotfix2
Choose a base branch
from

Conversation

maqi
Copy link
Member

@maqi maqi commented Mar 8, 2025

Description

find_closest_local_peers only return replication_factor number of results, which was expected to return K_VALUE results.
it shall be get_closest_local_peers to be used instead.

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)

@maqi maqi added the DoNotMerge label Mar 8, 2025
@maqi maqi force-pushed the get_closest_correction branch from 075d43f to 06e1472 Compare March 8, 2025 20:36
@maqi maqi changed the title TRYOUT fix(network): shall use get_closest_local_peers instead of find_closest Mar 8, 2025
@maqi maqi removed the DoNotMerge label Mar 8, 2025
@maqi maqi force-pushed the get_closest_correction branch from 06e1472 to a9ba091 Compare March 8, 2025 21:35
@maqi maqi force-pushed the get_closest_correction branch from a9ba091 to 0ddf63d Compare March 8, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant