Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): simplify the bootstrap cache to be a fifo #2764

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

RolandSherwin
Copy link
Member

@RolandSherwin RolandSherwin commented Feb 19, 2025

  • Simplify the bootstrap cache to be a FIFO.
  • Since there is a change in struct, we've also introduced some backwards compatibility such that we are able to write the cache in the old format.
    • This is required mostly by our public bootstrap cache, which can still be used by nodes running the older version of the code.
  • Introduce --write-older-cache-file argument for antnode and antctl. This also writes the argument inside the antctl's NodeRegistry to preserve the arg during upgrades.
  • Add more tests for the ant bootstrap crate.

@RolandSherwin RolandSherwin force-pushed the fifo_bootstrapp branch 2 times, most recently from 90df0e1 to e09bbef Compare February 27, 2025 19:57
@RolandSherwin RolandSherwin changed the base branch from rc-2025.1.2-hotfix1 to main February 27, 2025 19:57
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@RolandSherwin RolandSherwin force-pushed the fifo_bootstrapp branch 2 times, most recently from 5974933 to 076bc9d Compare February 27, 2025 21:10
@RolandSherwin RolandSherwin force-pushed the fifo_bootstrapp branch 2 times, most recently from a9cbb8f to dd45420 Compare March 4, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant