Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

maidsafe / autonomi Public

Notifications You must be signed in to change notification settings
Fork 62
Star 122

Code
Issues 67
Pull requests 16
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rpc in antctl with metric service #2670

Open

ermineJose wants to merge 17 commits into maidsafe:main

base: main

Choose a base branch

Loading

Loading

from ermineJose:drop-Rpc-replace-Metrics

Open

Replace rpc in antctl with metric service #2670

ermineJose wants to merge 17 commits into maidsafe:main from ermineJose:drop-Rpc-replace-Metrics

Conversation 26 Commits 17 Checks 49 Files changed

Conversation

Copy link

Contributor

ermineJose commented Jan 25, 2025 •

edited

Loading

Description

ant-node-manager currently uses rpc server to collect node_information and network_information, replace the rpc server with metric server.

Related Issue

Fixes #<issue_number> (if applicable).

Type of Change

Please mark the types of changes made in this pull request.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

I have read the contributing guidelines.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
I have updated the documentation accordingly.
I have followed the conventional commits guidelines for commit messages.
I have verified my commit messages with commitlint.

Sorry, something went wrong.

All reactions

ermineJose force-pushed the drop-Rpc-replace-Metrics branch from 3786eb7 to cb994a9 Compare

January 28, 2025 15:55

github-advanced-security bot found potential problems

View reviewed changes

ant-networking/src/metrics/service.rs Dismissed Show dismissed Hide dismissed

ant-node-manager/src/cmd/node.rs Fixed Show fixed Hide fixed

ant-service-management/src/metric.rs Fixed Show fixed Hide fixed

ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from b0761aa to 35433fc Compare

January 28, 2025 16:53

RolandSherwin reviewed

View reviewed changes

ant-networking/src/driver.rs Outdated Show resolved Hide resolved

RolandSherwin reviewed

View reviewed changes

ant-node/src/node.rs Outdated Show resolved Hide resolved

RolandSherwin reviewed

View reviewed changes

ant-service-management/src/metric.rs Outdated Show resolved Hide resolved

RolandSherwin reviewed

View reviewed changes

ant-service-management/src/metric.rs Outdated Show resolved Hide resolved

RolandSherwin reviewed

View reviewed changes

ant-service-management/src/lib.rs Show resolved Hide resolved

RolandSherwin reviewed

View reviewed changes

ant-service-management/src/metric.rs Outdated Show resolved Hide resolved

RolandSherwin reviewed

View reviewed changes

ant-service-management/src/metric.rs Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems

View reviewed changes

ant-service-management/src/metric.rs Fixed Show fixed Hide fixed

ermineJose force-pushed the drop-Rpc-replace-Metrics branch 5 times, most recently from 7f6233c to d7e2457 Compare

February 2, 2025 17:54

github-advanced-security bot found potential problems

View reviewed changes

ant-node-manager/src/lib.rs Fixed Show fixed Hide fixed

ant-node-manager/src/lib.rs Fixed Show fixed Hide fixed

ermineJose force-pushed the drop-Rpc-replace-Metrics branch 4 times, most recently from f884154 to 405c596 Compare

February 3, 2025 06:11

github-advanced-security bot found potential problems

View reviewed changes

ant-service-management/src/metric.rs Fixed Show fixed Hide fixed

ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from c3851ea to c92f726 Compare

February 5, 2025 07:21

ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from 8b1b43f to 41e2acc Compare

February 14, 2025 09:57

ermineJose marked this pull request as ready for review

February 14, 2025 09:58

github-advanced-security bot found potential problems

View reviewed changes

ant-node-manager/src/add_services/tests.rs Dismissed Show dismissed Hide dismissed

ant-node-manager/src/add_services/tests.rs Dismissed Show dismissed Hide dismissed

ant-node-manager/src/cmd/node.rs Dismissed Show dismissed Hide dismissed

ant-service-management/src/metric.rs Dismissed Show dismissed Hide dismissed

ermineJose force-pushed the drop-Rpc-replace-Metrics branch from 41e2acc to c7ab0bf Compare

February 14, 2025 10:05

ermineJose force-pushed the drop-Rpc-replace-Metrics branch 4 times, most recently from 5488501 to 262d7b0 Compare

February 18, 2025 18:08

ermineJose force-pushed the drop-Rpc-replace-Metrics branch from 262d7b0 to ee9994a Compare

February 24, 2025 08:43

ermineJose changed the title ~~Drop rpc replace metrics~~ Replace rpc in antctl with metric service

ermineJose added 17 commits

February 26, 2025 21:19


          feat: replace metric_service with rpc in antctl

9fdf5bd


          fix: add proper error handling to metric service support

62928b9


          feat: add proper listeners fetching support

243dff0


          feat: remove connected_peer display from antctl temporarily

ae8c367


          feat: add set root_dir method to NetworkBuilder

c5a516d


          feat: remove connected_peer support from metrics server temporarily

1c66fab


          feat: pass root_dir as variable to metric server

5c1605b


          feat: replace RpcActions with MetricActions


          fix: fix typos

1d166e7


          fix: support metric client with local tests

e7368dd


          feat: refactor antctl tests with metric service

0b59587


          feat: remove rpc from antctl and service

e80defe


          refactor: remove rpc_soc_addr instances

be2a8e7


          refactor: make rpc_soc_address as optional and remove other rpc insta…

304fa7a

…nces


          test: refactor antctl tests to remove rpc

e8b6f44


          refactor: add proper formatting

b0accbb


          fix: listener_addr issue in network_info

b65355e

ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from b9a531e to b65355e Compare

February 27, 2025 07:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jacderida jacderida left review comments

RolandSherwin RolandSherwin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.