Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launchpad): use default path for nodes data dir when root(unix) #2589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harismuzaffer
Copy link
Contributor

@harismuzaffer harismuzaffer commented Jan 1, 2025

Description

when launchpad is run as root(on unix) and base directory is same as primary mount point, use default path instead. Otherwise currently default is to use user's data directory which in case of root, is not accessible to user ant(against which antnode binary runs)

Here is the github issue: #2584

@harismuzaffer harismuzaffer force-pushed the use-default-nodes-dir-root-primary-mt-pt branch 2 times, most recently from 93c757a to a0cf28e Compare January 1, 2025 10:21
@RolandSherwin RolandSherwin self-assigned this Mar 5, 2025
Copy link
Member

@RolandSherwin RolandSherwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me 😄

…mary mount pt

When launchpad is run as root(on unix) and base directory is same as primary mount point,
use default path instead, otherwise default is to use user's data directory which in case of root,
is not accessible to user ant(against which antnode binary runs)
@RolandSherwin RolandSherwin force-pushed the use-default-nodes-dir-root-primary-mt-pt branch from d344a1a to cfa60c4 Compare March 5, 2025 09:49
@RolandSherwin RolandSherwin enabled auto-merge March 5, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants