Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for issue #158 #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wcooley
Copy link
Contributor

@wcooley wcooley commented May 31, 2018

@wcooley
Copy link
Contributor Author

wcooley commented May 31, 2018

I have attached the pytest output: 2 passing and 4 failing.

wcooley added a commit to wcooley/boltons that referenced this pull request May 31, 2018
This makes only one more test pass (now only 3 failing) but at least
prevents the `TypeError` when attempting to add a `list` and a `tuple`.
@mahmoud
Copy link
Owner

mahmoud commented Feb 11, 2019

Closing per comment in #160 (TL;DR, fixed in boltons==19.0.0)

@mahmoud mahmoud closed this Feb 11, 2019
@mahmoud
Copy link
Owner

mahmoud commented Feb 11, 2019

Hmm, TL;DR, I thought I was closing a different issue, reopening!

@mahmoud mahmoud reopened this Feb 11, 2019
mahmoud pushed a commit that referenced this pull request Jan 15, 2022
* Add test cases for issue #158

* Fix TypeError w/issue #158 and PR #159

This makes only one more test pass (now only 3 failing) but at least
prevents the `TypeError` when attempting to add a `list` and a `tuple`.

* Fix: Expected results should be `https://host/b`

* Provide parameters via `path`

* Move test case after `test_navigate`

Co-authored-by: Wil Cooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants