Skip to content

Cleanup code (originally profession-related) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bluebear94 wants to merge 14 commits into
base: 1.20-Forge
Choose a base branch
from
Open

Cleanup code (originally profession-related) #39

bluebear94 wants to merge 14 commits into from

Conversation

@bluebear94
Copy link

@bluebear94 bluebear94 commented Oct 19, 2025 •
edited
Loading

This PR improves the quality of some of the code surrounding professions.

  • Make the fields in SkillItemTier final.
  • Switch to EnumMap for mapping from SkillItemTiers to the respective items.
    • This might become moot if/when SkillItemTiers become configurable, but in any case, the type of TIERED_ITEM_MATS is now exposed as Map<..., Map<...>> instead of mentioning the concrete types.
  • Hoist map lookups in ProfessionMapItems#init so we don’t have to look up the elements once for every tier.
  • Generify BaseGearType#tags field and BaseGearType#getTags() method.
  • Improvements to AllyOrEnemy:
    • Avoid serializing entity data in NoAI check in AllyOrEnemy.non_ai_enemies.
    • Use pattern matching to avoid some casts.
    • Add default implementation for AllyOrEnemy#getMatchingEntities.

@bluebear94 bluebear94 force-pushed the mf/cleanup-professions branch 2 times, most recently from a1f9902 to 855778d Compare October 24, 2025 06:25
@bluebear94 bluebear94 changed the title Cleanup profession-related code Cleanup code (originally profession-related) Oct 26, 2025
@bluebear94 bluebear94 force-pushed the mf/cleanup-professions branch from 41e467d to 11e7a0b Compare October 31, 2025 19:16
@bluebear94
Set gradlew’s executable bit for Linux and macOS developers
1a5e4df
@bluebear94
SkillItemTier: make fields final
d64b218
@bluebear94
Use EnumMap for mapping between SkillItemTier and RegObj<Item>
d089589
@bluebear94
ProfessionMatItems#init: hoist map lookups outside of loop
d598404
@bluebear94
Remove stray import
e1492c2
@bluebear94
BaseGearType: generify tags field
8ee9c9b
@bluebear94
AllyOrEnemy: avoid serializing entity data in NoAI check
27f27b5
@bluebear94
AllyOrEnemy: use pattern matching to avoid casts
74751ca
@bluebear94
Add default implementation for AllyOrEnemy#getMatchingEntities
fa7352d
@bluebear94
ComponentPart#tryAcivate: simplify filtering by predicate
3f7e75d
@bluebear94
CooldownsData: optimize ticking methods
defd2ce
@bluebear94
ParticleRadiusAction: avoid dupilcate lookup of area multi
9f63921
@bluebear94
PotionAction: optimize REMOVE_NEGATIVE mode
22cf685 
This avoids building a new list for every effect stack to remove.
We do have to build a list once to avoid a CME, but we also limit
its length to `count`.
@bluebear94
Profession#getAllDrops: avoid duplicate lookup into tiered_drops
a7794dc
@bluebear94 bluebear94 force-pushed the mf/cleanup-professions branch from b7135c7 to a7794dc Compare November 16, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bluebear94