forked from RobertSkalko/Mine-And-Slash-Rework
-
Notifications
You must be signed in to change notification settings - Fork 6
Implementation of onExpire system and New Ui Elements for Thresholds #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dubledice
wants to merge
29
commits into
mahjerion:1.20-Forge
Choose a base branch
from
Dubledice:pr/onExpire+newUi
base: 1.20-Forge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains (NEW) API + Event Hooks. Contains Refactored/Factored Code. Desc: Made for new "WHILE_LEECHING" system. Also houses new HasExileEffectCondition, e.g. allowing WHILE_(...) tags.
Implemented brand new Resource Threshold fetcher, tracking ALL resources for conditional stats/effects. Desc: Completely Datapack driven.
Suggested Fixes: Datapack Threshold
Suggested Fixes: Extension
Suggested Fixes: Cleanup
Suggested Fixes: SpendThresholdManager.java
Pr/suggested fixes
Fixed effect consumption logic for certain effects like Overheat.
|
I don't know what's the right decision, but if I were the owner, I would ask Dice to rewrite this PR. Main change would be adding a new field
This would bring us to generic exile effect: |
ee39b40 to
f8ba63f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to Parent Branch
Commits summarized:
Addition of onExpire effect system, allowing for effects to be applied to the player when a prior effect ends.
Addition of Ui elements to support threshold effects, giving players a tracker to see when they hit their threshold breakpoint.
Cleaned up useless comments
General:
All new systems should be datapack-friendly.
Includes changes from my first and second PR request so + and - are inflated. <- New stuff starts here: onExpire + Ui Implementation