Generify registration #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Marking this as a draft since all other dependents of LoE are likely to need updates, so I don’t foresee this being accepted for a while. I guess the one saving grace is that it doesn’t break binary compatibility, so we can take our time to update every dependent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
ExileRegistryTypegeneric with respect to the type of object being registered and changes code to use generic types more consistently to reduce the number of unchecked casts in the codebase. I wished to avoid breaking API, but this is a lot harder to do than with #4, and some things in the Mine and Slash code are broken anyway, so…Must be applied concurrently with mahjerion/Mine-And-Slash-Rework#51