-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed loading single player worlds with mod enabled #56
base: develop
Are you sure you want to change the base?
Conversation
One requirement is to be able to use "Open to LAN" and have the mod work. Does this PR prevent that? |
I think this will. What I could do is add an event for when you start a lan server, you will change a boolean to true and include that in the check. I won't be able to do it tonight but I can check tomorrow or the day after. |
I believe I have fixed LAN servers with f371aaf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to need evidence of the " unneeded strain" and the "crash which occurs" that you talked about in the main PR body. I've been using this mod on my own singleplayer world and haven't encountered a crash or been able to measure any strain.
I am not entirely sure if it caused by another mod or not, but this has fixed it. I can also measure the strain when opening the world and it uses more memory, unnecessarily as it is a singleplayer world. |
I'd love any crash logs you have! Open an issue and post the relevant parts please! This PR can be to fix whatever incompatibility is causing the crashes. |
Checks to make sure the server is a dedicated server before linking to mumble in order to fix unneeded strain and also fix the crash which occurs.
MixinPlayerManager.java:
MixinServerPlayerEntity.java:
• I added a check to fix crashes
ClientMumbleLinkMod.kt:
• I added a check to remove unneeded strain on the singleplayer world