Skip to content

Typing #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Typing #673

wants to merge 7 commits into from

Conversation

sakgoyal
Copy link

Related to: #148

  • remove support for out of date python version
    • add support for 3.13
  • strict type errors in IDE
  • use f-strings

@sakgoyal
Copy link
Author

There are some issues still. but I need feedback to know if im on the right track

@Cube707
Copy link
Collaborator

Cube707 commented Apr 11, 2025

Please split mulltiple concernes into multiple PRs. Updating the python versions is unrelated to type hinting. Same for f-strings

Never commit editor specific files.

If we add type hinting, we also need to test for it in CI/CD

Once you are done, please Squash the commits into atomic ones with a good commit-message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magmax magmax Awaiting requested review from magmax magmax will be requested when the pull request is marked ready for review magmax is a code owner

@Cube707 Cube707 Awaiting requested review from Cube707 Cube707 will be requested when the pull request is marked ready for review Cube707 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakgoyal @Cube707