Feat: Print websocket port on startup #351
Open
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
test-bins/src/rpc.rs
Outdated
Comment on lines
78
to
79
| info!("📡 RPC endpoint: http://{:}:{}", rpc_host, rpc_port); | ||
| info!("🔌 WebSocket endpoint: ws://{}:{}", rpc_host, ws_port); |
There was a problem hiding this comment.
syntax: Inconsistent formatting between RPC and WebSocket endpoints - one uses {:} and the other uses {}
There was a problem hiding this comment.
Agreed, pleas use {} for uniformity.
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
GabrielePicco
requested changes
Apr 29, 2025
test-bins/src/rpc.rs
Outdated
Comment on lines
78
to
79
| info!("📡 RPC endpoint: http://{:}:{}", rpc_host, rpc_port); | ||
| info!("🔌 WebSocket endpoint: ws://{}:{}", rpc_host, ws_port); |
There was a problem hiding this comment.
Agreed, pleas use {} for uniformity.
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
4rjunc
commented
Apr 29, 2025
| info!(""); | ||
| info!("🧙 Magicblock Validator is running!"); | ||
| info!("-----------------------------------"); | ||
| info!("📡 RPC endpoint: http://{}:{}", rpc_host, rpc_port); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #320
Greptile Summary
Enhanced startup messaging to display both RPC and WebSocket endpoint information, improving clarity by showing the conventional WebSocket port (RPC port + 1) during validator initialization.
/test-bins/src/rpc.rs(RPC port + 1)💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!