Improve performance of signups calendar #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also returns your new weighted hours so we can keep that updated.
Also fades the text in and out for your weighted hours.
|
The build here is expected to fail as this branch was started before the build fix was pushed into the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should (hopefully) dramatically improve the performance of the signups calendar by rewriting the call for assigned shifts so it stops generating so many DB queries.
There's less that we can immediately do about the call for available jobs, since there's so much processing that happens to figure out what jobs you can actually sign up for. We'll want to tackle that later, but in the meantime, we've added caching to the page so that switching to List view no longer re-fetches jobs from the server (thank you Hayley!).
We also now update the "you are signed up for X hours" text when you sign up for and drop a shift, so people don't have to refresh the page to see their current hours total.