Fixes for dealer badge conversion, email reports, and admin shift schedule #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior form of this would always delete the group leader when deleting the group, which is... not ideal. Also fixes an issue with the email.
This should stop these validations from running on non-prereg pages, even if someone is claiming a new badge.
Registration doesn't need to do anything with pending attendees that hadn't finished registering, so this was just filling up their inboxes.
Turns out we have a way to check for email subjects that have already been sent!
It's not really important but I saw it so I had to fix it
The "Event" button on the shift management page for admins was showing up until the epoch day, but not the actual last day of the event. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following fixes: