Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3243 :PWA Store View Not Functioning for Taiwan Store View with L… #4273

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

glo85315
Copy link
Contributor

…anguage Locale 'zh_Hant_TW'

Description

TODO: PWA Store View Not Functioning for Taiwan Store View with Language Locale 'zh_Hant_TW'.

Taiwan Chinese store view using the language locale 'zh_Hant_TW' encountering an error in the console: 'Incorrect locale information provided.' As a result, the PWA application is not functioning. The issue is specific to the 'zh_Hant_TW' locale and other locale with has more than one underscore in locale code and rest language locales are working correctly.

Related Issue

Closes # https://jira.corp.adobe.com/browse/PWA-3243

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo85315 glo85315 requested a review from glo82145 May 31, 2024 04:31
@glo85315 glo85315 added pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes. labels May 31, 2024
@pwa-studio-bot
Copy link
Collaborator

Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3243.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 401021a

@glo82145 glo82145 merged commit 6116252 into develop Jul 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants