fix(review): prevent product state modification in Review block #40510
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Removed
$product->setShortDescription(null);fromMagento\Review\Block\Product\View::_toHtml().This line was modifying the product object stored in the registry, causing side effects for any subsequent code that accessed the product - they would see
nullforshort_descriptioninstead of the actual value.The short description block is now hidden via layout XML (
remove="true") on the review page, achieving the same visual result without mutating the model.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
/review/product/list/id/{product_id}) - short description should be hiddenshort_descriptionattribute retains its value when accessed from other blocks/codeQuestions or comments
Contribution checklist (*)
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz