Skip to content

fix(mftf): resolve Add Products button timing flakiness MC-15861 #40483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lbajsarowicz wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

fix(mftf): resolve Add Products button timing flakiness MC-15861 #40483

lbajsarowicz wants to merge 1 commit into from

Conversation

@lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Feb 2, 2026 •
edited
Loading

Description

The "Add Products" button on the Admin Create Order page is dynamically injected by JavaScript (Magento_Sales/order/create/scripts.js). The button is added to #order-items .admin__page-section-title .actions via itemsArea.onLoad callback.

When AddSimpleProductToOrderActionGroup runs immediately after AdminNavigateToNewOrderPageExistingCustomerActionGroup, the button may not exist yet, causing:

CSS or XPath element with //section[@id='order-items']/div/div/button/span[text() = 'Add Products'] was not found.

Solution

Add waitForElementClickable before the click, following the pattern used in AddConfigurableProductToOrderActionGroup and CreateOrderInStoreActionGroup.

Fixed Issues

Testing

  • Affected action group is used by multiple Sales MFTF tests.
  • The wait ensures the button is present and clickable before interaction.

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

@lbajsarowicz
fix(mftf): resolve Add Products button timing flakiness MC-15861
db1255e 
The Add Products button is injected asynchronously by JavaScript in the
Create Order page. Add waitForElementClickable before click to avoid
race condition when button is not yet in DOM.

Fixes flaky AdminCreateCreditMemoPartialRefundTest (EE).
@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

lbajsarowicz commented Feb 2, 2026

@magento run all tests

@lbajsarowicz lbajsarowicz mentioned this pull request Feb 2, 2026
Open
5 tasks
lbajsarowicz added a commit to lbajsarowicz/magento2-contributions that referenced this pull request Feb 2, 2026
@lbajsarowicz
fix(mftf): resolve Fotorama image gallery flakiness in StorefrontAsse…
d4f463f 
…rtFotoramaImageAvailabilityActionGroup

Replace seeElement with waitForElementVisible to wait for async Fotorama gallery
loading before asserting image availability. Fixes NoSuchElementException for
.fotorama__nav__shaft img selector when gallery loads slower than expected.

Observed in: StorefrontConfigurableOptionsThumbImagesTest (Check thumbnail
images and active image for Configurable Product) during MFTF runs, e.g.
Allure report from PR magento#40483.
@lbajsarowicz lbajsarowicz mentioned this pull request Feb 2, 2026
Closed
5 tasks
@lbajsarowicz
Copy link
Contributor Author

lbajsarowicz commented Feb 2, 2026

@magento run Functional Tests CE, Functional Tests B2B

@engcom-Bravo engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label Feb 3, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Pull Requests Dashboard
Status: Pending Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lbajsarowicz @engcom-Bravo