Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: URL fragment in product detail page not working as expected #39599 #39639

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

ajay2108
Copy link

@ajay2108 ajay2108 commented Feb 18, 2025

Fix for URL fragment in product detail page not working.

Description (*)

This PR dynamically finds the index of the Reviews tab and explicitly activates it, ensuring that users are taken directly to the reviews section when reviews fragment entered in url on product detail page.

Related Pull Requests

None

Fixed Issues (if relevant)

  1. Fixes URL fragment in product detail page not working as expected #39599

Manual testing scenarios (*)

  1. Go to any product detail page
  2. Add URL fragment (e.g., #reviews)
  3. The reviews tabs becomes active with the rendered content, and the viewport is scrolled to the content.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Feb 18, 2025

Hi @ajay2108. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ajay2108
Copy link
Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL fragment in product detail page not working as expected
2 participants