Fix mime type typo #36669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ssx wants to merge 6 commits into magento:2.4-develop from ssx:patch-2

Contributor

ssx commented Dec 24, 2022 •

edited by m2-assistant bot

Loading

This PR fixes a typo in module-cms/Test/Unit/Model/Wysiwyg/Images/StorageTest.php

Resolved issues:

resolves [Issue] Fix mime type typo #36899: Fix mime type typo


          Fix mime type typo

3c2d78f

m2-assistant bot commented Dec 24, 2022

Hi @ssx. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Hotel added the Priority: P2 label

m2-community-project bot added the Progress: pending review label

fredden approved these changes

View reviewed changes

Member

fredden left a comment

This looks like a partial duplicate of #33514. I'm approving as the changes here look fine on their own.

m2-community-project bot assigned fredden

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels

magento-automated-testing bot commented Feb 1, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik approved these changes

View reviewed changes

m2-community-project bot assigned Den4ik

Contributor

Den4ik commented Feb 6, 2023

@fredden Thanks for the link. I have checked #33514 and believe first one is preferable for merge rather then this PR. I'm voting for the first one

Contributor

RaghavendraTirumalasetti commented Feb 14, 2023

@magento run Static Tests

magento-automated-testing bot commented Feb 14, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Contributor

RaghavendraTirumalasetti commented Feb 14, 2023

@magento run Integration Tests

magento-automated-testing bot commented Feb 14, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.


          Fixed static test failures

741e8f0

Contributor

engcom-Echo commented Feb 15, 2023

@magento run all tests

magento-automated-testing bot commented Feb 15, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels

engcom-Echo self-assigned this

m2-community-project bot added Progress: ready for testing Progress: accept and removed Progress: accept Progress: ready for testing labels

Contributor

engcom-Lima commented Feb 21, 2023

@magento create issue

m2-assistant bot mentioned this pull request

[Issue] Fix mime type typo #36899

Open

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels


          Merge branch '2.4-develop' into patch-2

5d83314

hostep reviewed

View reviewed changes

app/code/Magento/Cms/Test/Unit/Model/Wysiwyg/Images/StorageTest.php Outdated Show resolved Hide resolved

m2-community-project bot assigned hostep

m2-community-project bot added Progress: review and removed Progress: accept labels

hostep removed their assignment

magento-automated-testing bot commented Feb 27, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.


          Merge branch '2.4-develop' into patch-2

332d355

Contributor Author

ssx commented Dec 23, 2024 •

edited

Loading

@engcom-Hotel @engcom-Echo @engcom-Lima @engcom-Alfa @Den4ik @fredden

considering the other PR didn't get merged, can we get this one merged? or would you prefer me to duplicate those changes here? (I've got CLA signed)

sinhaparul added the Project: Community Picked label

ct-prd-projects-boards-automation bot added this to Community Dashboard

ct-prd-projects-boards-automation bot moved this to Review in Progress in Community Dashboard

ct-prd-projects-boards-automation bot removed this from Pull Requests Dashboard


          Merge branch '2.4-develop' into patch-2

2f4abed

Contributor

engcom-Hotel commented Jun 26, 2025

@magento run all tests

engcom-Hotel approved these changes

View reviewed changes

ct-prd-projects-boards-automation bot removed the Progress: review label

ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard

ct-prd-projects-boards-automation bot added the Progress: ready for testing label

engcom-Bravo self-assigned this

ct-prd-projects-boards-automation bot added Progress: testing in progress and removed Progress: ready for testing labels

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard


          Merge branch '2.4-develop' into patch-2

12664d4

Contributor

engcom-Bravo commented Jun 27, 2025

@magento run all tests

Contributor

engcom-Bravo commented Jun 27, 2025

Hi @ssx,

Thanks for the collaboration & contribution!

✔️ QA Passed

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard

engcom-Dash self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 Progress: testing in progress Project: Community Picked