magento/community-features#238: Don't trigger reload of ui listing at page load.

[Den4ik]

Description (*)

This PR is a re-creation of #31919

Related Pull Requests

magento/adobe-stock-integration#1859

Fixed Issues (if relevant)

1. Fixes Don't trigger reload of ui listing at page load community-features#238: Don't trigger reload of ui listing at page load.

Manual testing scenarios (*)

1. See Don't trigger reload of ui listing at page load community-features#238: Don't trigger reload of ui listing at page load.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Den4ik. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Den4ik]

@magento run all tests

[ihor-sviziev]

@magento run Integration Tests

[ihor-sviziev]

Could you check the failing functional tests?

[Den4ik]

Could you check the failing functional tests?

Hi, @ihor-sviziev I'm working on rework of this PR.

[Den4ik]

@magento run all tests

[Den4ik]

@magento run all tests

[Den4ik]

@magento run all tests

[Den4ik]

@magento rull all tests

[Den4ik]

@magento run all tests

[Den4ik]

@magento run Unit Tests

[Den4ik]

@magento run Unit Tests

[Den4ik]

@magento run all tests

[engcom-Hotel]

Hello @Den4ik,

This is a gentle reminder to resolve the conflicts on this PR so we can proceed with this.

Thanks

[engcom-Hotel]

Hello @Den4ik,

We appreciate your contribution!

Unfortunately, we haven't received a response from you for an extended period, so we are closing this PR for now.

Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you.

Thanks once again!

[alexgran]

Is there something we can assist here to get that done?

[m2-assistant]

Hi @Den4ik. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

Hello @Den4ik,

Please resolve the conflicts of this PR, so that we can move further with this PR.

Thanks

[Den4ik]

Hi @engcom-Hotel
I'm working on updates

[engcom-Hotel]

Hello @Den4ik,

Have you got a chance to resolve the conflicts on this PR?

Thanks

[engcom-Charlie]

Hi @Den4ik,

As you have marked this PR as draft, moving this to On Hold status. Please feel free to reopen once its ready.

Thank you!

[engcom-Hotel]

As discussed on Slack, @Den4ik will resolve the conflicts at the earliest. In the meantime, we will keep this PR On Hold.

Thank you.

[engcom-Hotel]

Hello @Den4ik,

Have you got chance to work on this PR?

Thanks

[Den4ik]

Hi @engcom-Hotel
Yes, I'm finishing with it and hope push update in a few days

[magedad]

Thank you @Den4ik, I can see your effort on this issue. I appreciate your work.
Does the plugin work temporarily?

public function aroundGetData(DataProvider $subject, \Closure $callback)
{
    return $this->request->getParam('isAjax') ? $callback() : [];
}

[Den4ik]

Hi @magedad,
Sorry for delay with answer. What plugin you mean?

[magedad]

Hi @magedad, Sorry for delay with answer. What plugin you mean?

@Den4ik

#32998

[Den4ik]

@magedad,
The primary issue with the proposed solution is that it retains the second request. An AJAX call is still made to the server to fetch the data, while my solution relies on a single request only.

[engcom-Hotel]

Hello @Den4ik,

As per confirmation on slack, you are going to resolve the conflicts on this PR 1 or 2 weeks, did you get a chance to look into this?

Thanks

[engcom-Hotel]

Hello @Den4ik,

Have you got a chance to look into this PR?

Thanks

[engcom-Hotel]

Hello @Den4ik,

We appreciate your contribution!

Since we haven't received a response from you for an extended period, we are closing this PR for now.

Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you.

Thanks once again!

[lbajsarowicz]

This is disappointing @engcom-Hotel . If only you were open to fix that issue on your side, at least...

[engcom-Hotel]

Hi @lbajsarowicz,

I understand there's disappointment regarding the closure of this PR, and I'd like to provide some clarity.

According to our contribution guidelines, while the Magento team can assist with failing automated tests and other issues, resolving merge conflicts must be handled by the PR author. This is because conflicts require understanding of the code changes and intent behind them, which only the original contributor can properly address.

We did reach out previously requesting conflict resolution, but understand that @Den4ik were unable to resolve them due to occupancy in other commitments.

Next steps options:

• If you're still interested in contributing this feature, you could create a new PR based on the current codebase to avoid conflicts or reopen this one and resolve the conflicts.

We greatly value all community contributions and apologize for any frustration this has caused. If you need guidance on creating a new PR or have any questions, please let us know.

Thank you for your understanding.