Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2487: Add dispatch thread check before applying fix #2498

Merged
merged 2 commits into from
Feb 23, 2025
Merged

2487: Add dispatch thread check before applying fix #2498

merged 2 commits into from
Feb 23, 2025

Conversation

vitaliyboykocontributor
Copy link
Contributor

Ensures that applyFix is only called on the dispatch thread to prevent potential threading issues. This change improves safety and aligns with IntelliJ threading requirements.

Description (*)

Fixed Issues (if relevant)

  1. Fixes Must not start write action from within read action in the other thread #2487

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko
2487: Add dispatch thread check before applying fix
9b5f580 
Ensures that `applyFix` is only called on the dispatch thread to prevent potential threading issues. This change improves safety and aligns with IntelliJ threading requirements.
@VitaliyBoyko
2487: Add changelog entry for threading fix
db9a41e 
Include details of the threading issue addressed to improve clarity in the changelog. This ensures developers are aware of the fix and its context.
@VitaliyBoyko VitaliyBoyko merged commit dc30b4a into magento:5.4.0-develop Feb 23, 2025
5 checks passed
@VitaliyBoyko VitaliyBoyko deleted the 2487-Must-not-start-write-action-from-within-read-action-in-the-other-thread- branch February 23, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels
Progress: done
Projects
Pull Request Progress
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Must not start write action from within read action in the other thread
3 participants
@vitaliyboykocontributor @VitaliyBoyko @magento-ct-gh-projects-svc