-
Notifications
You must be signed in to change notification settings - Fork 155
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed #76: corrects the assumption that basename provides a unique co…
…mparison.
- Loading branch information
David Alger
committed
Mar 5, 2014
1 parent
5e3730d
commit c812c5c
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,7 @@ public function createDelegate($source, $dest) | |
// Namespace/ModuleDir => Namespace/ModuleDir, but ModuleDir may exist | ||
|
||
if (file_exists($destPath) && is_dir($destPath)) { | ||
if (basename($sourcePath) === basename($destPath)) { | ||
if (strcmp($dest, $source) === 0) { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
davidalger
via email
|
||
// copy each child of $sourcePath into $destPath | ||
foreach (new \DirectoryIterator($sourcePath) as $item) { | ||
$item = (string) $item; | ||
|
Unfortunately this change seems to have some negative side effects. Since 2.0.0-beta2 we are experiencing the following behaviour: