-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DFT] Guidelight Matrix and Kolodin, Triumph Caster #13411
[DFT] Guidelight Matrix and Kolodin, Triumph Caster #13411
Conversation
add static method from SaddleAbility to saddle a permanent add common saddle effect refactor Alacrian Armory with new saddle effect
@Override | ||
public boolean apply(Game game, Ability source) { | ||
Permanent targetMount = game.getPermanent(getTargetPointer().getFirst(game, source)); | ||
if (targetMount == null || !targetMount.hasSubtype(SubType.MOUNT, game)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Target Mount" should be handled in target filter, so I don't think this is necessary
this.addAbility(new EntersBattlefieldTriggeredAbility(new DrawCardSourceControllerEffect(1))); | ||
// {2}, {T}: Target Mount you control becomes saddled until end of turn. Activate only as a sorcery. | ||
Ability saddledAbility = new ActivateAsSorceryActivatedAbility(new SaddleTargetMountEffect(), | ||
new CompositeCost(new ManaCostsImpl<>("{2}"), new TapSourceCost(), "{2}, {T}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add costs instead of creating a single CompositeCost
changed SaddleTargetMountEffect apply to pass first target changed GuidelightMatrix to not use composite cost
Cards updated, thanks |
…light-matrix-kolodin # Conflicts: # Mage.Sets/src/mage/sets/Aetherdrift.java
For #13033
This PR adds both Guidelight Matrix and Kolodin, Triumph Caster. Also, because both of these cards cause mounts to become saddled, the PR also includes changes to create a common effect to saddle a target and adding a static ability to Saddle class. Additionally, Alacrian Armory is refactored to use the new method.