[DFT] Implement Full Throttle #13409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Mar 19, 2025
| controllerId = source.getControllerId(); | ||
| break; | ||
| case ANY: | ||
| controllerId = game.getActivePlayerId(); |
There was a problem hiding this comment.
Looks like you changed logic? Why separate TargetController anyway?
Default constructor puts it as TargetController.YOU, but that id is not the same as the old code.
Can you please explain? Also, is there test coverage on this class?
There was a problem hiding this comment.
Oh I see that was removed in the next commit, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #13033
This card adds an engine change for AdditionalCombatPhaseEffect to allow more than one additional phase. The change also allows for setting yourself or any player to add phases.