Skip to content

Conversation

@simsComputing
Copy link
Contributor

@simsComputing simsComputing commented Apr 13, 2025

Description (*)

I have fixed all integration tests on Magento_Backend and Magento_Bundle. For the first one it was about rewriting the test to adapt it to the class's new dependencies.
For the second one it was about fixing Magento.

I added fixes for the Magento_CatalogInventory module. It was about fixing the integration with the new ParentItemProcessInterface

Fixed Issues (if relevant)

I cannot access github issues on the mage-os repo. So here is the taiga ticket :


Fix all broken integration tests

But the PR for now does not fix all integration tests. it will be a long way to go.

Manual testing scenarios (*)

First make sure you're in the dev/tests/integration folder. then :

  1. ../../../vendor/bin/phpunit testsuite/Magento/Backend
  2. ../../../vendor/bin/phpunit testsuite/Magento/Bundle
  3. ../../../vendor/bin/phpunit testsuite/Magento/CatalogInventory

You should have 0 broken test

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@simsComputing simsComputing requested a review from a team as a code owner April 13, 2025 17:48
@rhoerr
Copy link
Contributor

rhoerr commented May 20, 2025

Hi! Just wondering, should we have this be a draft PR for now, while you work on more fixes? Or do you want to split your work into multiple PRs, and have us process this one now as-is?

It might be good to do multiple PRs, so that each individual PR is smaller for review. That way we could get things merged faster and more often for you, too.

@humeauantadis
Copy link

Hi @rhoerr , yes of course you're right. Plus i should rewrite the description of the PR since it now contains a few more things.
I can stop here on that PR. Should we split the taiga task also ?

@rhoerr
Copy link
Contributor

rhoerr commented Jun 1, 2025

I can stop here on that PR. Should we split the taiga task also ?

We can keep the same Taiga task for tracking. 🙂 You can add subtasks to it if you would like.

Copy link
Contributor

@rhoerr rhoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed work to date, some mostly small feedback

@simsComputing
Copy link
Contributor Author

@rhoerr , i just made the changes required. Can you please check ? Thank you

@rhoerr rhoerr self-requested a review July 15, 2025 19:30
rhoerr
rhoerr previously approved these changes Jul 22, 2025
@rhoerr
Copy link
Contributor

rhoerr commented Jul 22, 2025

Looks good to me. Thank you @simsComputing. @fballiano what do you think?

@fballiano
Copy link
Contributor

Applied 2 minor whitespace changes reported by PHPCS, will approve and try to merge as soon as the workflows finish

@fballiano fballiano merged commit 5293fb8 into mage-os:2.4-develop Jul 22, 2025
4 of 8 checks passed
@fballiano
Copy link
Contributor

@rhoerr should we cherry pick this to release/1.x?

rhoerr added a commit that referenced this pull request Aug 13, 2025
Fix integration tests for Magento_Backend and Magento_Bundle (Cherry-picked PR #134 into `release/1.x`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants