-
Notifications
You must be signed in to change notification settings - Fork 58
Fix integration tests for Magento_Backend and Magento_Bundle #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests for Magento_Backend and Magento_Bundle #134
Conversation
dev/tests/integration/testsuite/Magento/Bundle/_files/issaleable_product.php
Outdated
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Bundle/_files/issaleable_product.php
Outdated
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Bundle/_files/issaleable_product.php
Outdated
Show resolved
Hide resolved
|
Hi! Just wondering, should we have this be a draft PR for now, while you work on more fixes? Or do you want to split your work into multiple PRs, and have us process this one now as-is? It might be good to do multiple PRs, so that each individual PR is smaller for review. That way we could get things merged faster and more often for you, too. |
|
Hi @rhoerr , yes of course you're right. Plus i should rewrite the description of the PR since it now contains a few more things. |
We can keep the same Taiga task for tracking. 🙂 You can add subtasks to it if you would like. |
rhoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed work to date, some mostly small feedback
app/code/Magento/ConfigurableProduct/Model/Inventory/ParentItemProcessor.php
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Customer/Model/ResourceModel/Grid/CollectionTest.php
Outdated
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Downloadable/_files/quote_with_downloadable_product.php
Outdated
Show resolved
Hide resolved
|
@rhoerr , i just made the changes required. Can you please check ? Thank you |
|
Looks good to me. Thank you @simsComputing. @fballiano what do you think? |
dev/tests/integration/testsuite/Magento/Bundle/_files/issaleable_product.php
Outdated
Show resolved
Hide resolved
|
Applied 2 minor whitespace changes reported by PHPCS, will approve and try to merge as soon as the workflows finish |
|
@rhoerr should we cherry pick this to release/1.x? |
Fix integration tests for Magento_Backend and Magento_Bundle (Cherry-picked PR #134 into `release/1.x`)
Description (*)
I have fixed all integration tests on Magento_Backend and Magento_Bundle. For the first one it was about rewriting the test to adapt it to the class's new dependencies.
For the second one it was about fixing Magento.
I added fixes for the Magento_CatalogInventory module. It was about fixing the integration with the new ParentItemProcessInterface
Fixed Issues (if relevant)
I cannot access github issues on the mage-os repo. So here is the taiga ticket :
Fix all broken integration tests
But the PR for now does not fix all integration tests. it will be a long way to go.
Manual testing scenarios (*)
First make sure you're in the dev/tests/integration folder. then :
You should have 0 broken test
Contribution checklist (*)