Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override "Unknown" Status as "Critical" for status check with cli switch #17

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Override "Unknown" Status as "Critical" for status check with cli switch #17

wants to merge 36 commits into from

Conversation

s256
Copy link

@s256 s256 commented Aug 12, 2021

  • adds another CLI switch for the status switch -unknown-as-critical to treat UNKNOWN errors as CRITICAL.

#15

madrisan and others added 30 commits April 27, 2020 23:36
@madrisan
Send all the messages to stdout in Nagios compliant mode
b1477d2 
This is required because, as pointed out by unix196, Nagios shows
an empty output in case of warning and error messages.

Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Completely disable colored output in the nagios outputter
1e5409f 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Merge pull request madrisan#7 from madrisan/issue_6
be52603 
Send all the messages to stdout and with no colours when the Nagios outputter is selected
@madrisan
build: build the configuration for circleci
548183c 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
build: fix No rule to make target 'ci-bootstrap'
902e35c 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
build: update travis configuration
49b6ba0 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
README: remove the badge for circleci
7ed8b81 
The configuration for circleci is currently bloken.
Revove the badge for now.

Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Use go modules.
c1ed5ea 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Add a configuration file for semaphore CI
d0411ae 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the configuration for semaphore CI
b21c4ea 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the configuration for semaphore CI
5f850d5 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the configuration for semaphore CI
f7781d8 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the configuration for semaphore CI
48d55ac 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the configuration for semaphore CI
d05b82e 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the configuration for semaphore CI
22968a2 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the configuration for semaphore CI
91398a9 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update the build badges
9789fb8 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Merge pull request madrisan#9 from madrisan/go_modules
7303ea3 
Use go modules to fix the CI configurations
@madrisan
travis-ci: switch to go 1.13
326a897 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Merge pull request madrisan#10 from madrisan/travis_conf
377c61d 
travis-ci: switch to go 1.13
@maxadamo
include error message in output
560ef6b
@madrisan
Merge pull request madrisan#11 from maxadamo/master
a69a389 
Include the error message in output when reading the environment variables.
@madrisan
Update semaphore CI configuration
70a63e7 
Build and run tests also with go 1.14.

Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update circle CI configuration
f7feaf7 
Build and run tests also with go 1.14.

Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Switch to go 1.14 in travis CI build
542c899 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Update CI badges in the README documentation file
196dc5f 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Merge pull request madrisan#13 from madrisan/golang_1_14
99c9a96 
Update CI configurations
@madrisan
Version 0.8.5
4901da1 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Add a new logo image for hashicorp-vault-monitor
f7f7133 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Make the logo image more consist with the other image names
33db2ae 
Signed-off-by: Davide Madrisan <[email protected]>
@madrisan
Copy link
Owner

Why did you marked as (only relevant for output="nagios") in the help message?
The return code is relevant in both the the default and the nagios output.

@madrisan
Copy link
Owner

madrisan commented Aug 12, 2021 •
edited
Loading

Also the help message (exit status) should be updated.

--- a/command/status.go
+++ b/command/status.go
@@ -50,7 +50,7 @@ Usage: hashicorp-vault-monitor status [options]
        Specify an output format. Can be 'default' or 'nagios'.
 
     -unknown-as-critical
-       Every unknown error is treated as critical(only relevant for output="nagios").
+       Every unknown error is treated as critical.
 
   The exit code reflects the seal status:
 
@@ -58,6 +58,8 @@ Usage: hashicorp-vault-monitor status [options]
       - %d - the vault node is sealed
       - %d - an error occurred
 
+  The last case will be merged into the second one if -unknown-as-critical is selected.
+
   For a full list of examples, please see the online documentation.
 `
        return fmt.Sprintf(helpText,

@madrisan madrisan linked an issue Aug 12, 2021 that may be closed by this pull request
Nagios output state is "unknown" on "Connection Refused" e.g. stopped service #15
Open
@madrisan
Copy link
Owner

Seem good to me. Thanks!

@madrisan madrisan force-pushed the master branch 4 times, most recently from dbc1d33 to 76c354b Compare November 27, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nagios output state is "unknown" on "Connection Refused" e.g. stopped service
3 participants
@s256 @madrisan @maxadamo