Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add): prevent errors when supplying dependencies for Nuxt.js template #246

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Sep 20, 2023

What kind of change does this PR introduce?

bug fix

Did you add tests for your changes?

The existing test suite accounts for it.

If relevant, did you update the documentation?

N/A

Summary

Fixes #247

This PR fixes the issue about specifying dependencies to be installed with the add command fails for the Nuxt.js template irrespective of the directory client/server. The proposed fix skips from performing further configuration if the template chosen is Nuxt.js or the directory is server regardless of the template. All other starter templates have the client/src/main.js as a valid path, which wasn't the case with Nuxt.js. For the server directory, this isn't required since all configuration updates happen for dependencies relating to the client (vuex, vuetify, Nuxt modules, etc).

Does this PR introduce a breaking change?

No

Other information

N/A

@jamesgeorge007 jamesgeorge007 added the patch A PR that fixes a bug. label Sep 20, 2023
@jamesgeorge007 jamesgeorge007 merged commit ad04af6 into develop Sep 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A PR that fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying dependencies with the add command fails for the Nuxt.js template
1 participant