[WIP] GPU Abstraction to also target HIP in cudacpp impementation & Profiling infrastructure #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to gpu_abstraction
…UFLAGS to GPUFLAGS in cudacpp_src.mk
…ased on gg_ttgg.mad
[CODEGEN] Regenerate all 5 .sa/.mad processes based on gg_ttgg.mad
…rc.mk and cudacpp.mk
Removed all warnings in HIP compilation
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jan 25, 2024
I am working now in branch valassi/jthip24. This is my first commit over joorgen/gpu_abstraction branch (also known as valassi/jthip), as of commit 229ffeb (Tue Aug 15 11:33:01 2023 +0200). This branch contains fewer features than jooorgen/master (PR madgraph5#718), but it is more advanced than joorgen/gpu_abstraction_only (PR madgraph5#774). I will probably need some of the commits here to fix PR madgraph5#774 in branch valassi/jt774. I regenerate the ten processes as follows: ./CODEGEN/generateAndCompare.sh ee_mumu --mad ./CODEGEN/generateAndCompare.sh gg_tt --mad ./CODEGEN/generateAndCompare.sh gg_ttg --mad ./CODEGEN/generateAndCompare.sh gg_ttgg --mad ./CODEGEN/generateAndCompare.sh gg_ttggg --mad ./CODEGEN/generateAndCompare.sh ee_mumu ./CODEGEN/generateAndCompare.sh gg_tt ./CODEGEN/generateAndCompare.sh gg_ttg ./CODEGEN/generateAndCompare.sh gg_ttgg ./CODEGEN/generateAndCompare.sh gg_ttggg These are the five processes that would get conflicts when I merge upstream/master here, so I guess that these are the only ten processes touched in this branch. The fact that I can regenerate them and there are no real differences (except for irrelevant stuff like me5_configuration.txt, aloha_file.inc, py3_model.pkl) shows that ALL IMPORTANT CHANGES BY JORGEN HERE ARE IN THE CODEGEN. I can therefore merge upstream/master, fix conflicts in CODEGEN and regenerate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current work from the GPU abstraction I have been working on. Also includes the profiling infrastructure, but bear in mind the SYCL portion is not working as intended currently. Need some documentation from Nathan on how to compile it first.
Just ran it successfully on LUMI-G with MI250x GPUs. On a sidenote I seem to have an issue running on the GPUs we got from LHCb, but on LUMI it apperantly runs fine.
LHCb development GPUs (MI250x):
VS
LUMI-G GPUs (MI250x):