fix(convert): notify DOCX uploads with mixed-case extensions - #5594
Conversation
Signed-off-by: Mr-Neutr0n <harikp2002@gmail.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@services/convert_service/src/process/convert.rs`:
- Around line 133-148: Move the inline test module containing
docx_detection_accepts_mixed_case_extensions and
docx_detection_requires_the_final_extension from convert.rs into
process/test.rs. Replace the inline body in convert.rs with the separate-module
declaration #[cfg(test)] mod test;, preserving the existing imports and test
assertions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 999f1cdd-c1f3-4531-b619-c587407092cd
📒 Files selected for processing (1)
services/convert_service/src/process/convert.rs
whutchinson98
left a comment
There was a problem hiding this comment.
Hi @Mr-Neutr0n thanks for your contribution!
Just a minor nit then we are good to merge
Signed-off-by: Mr-Neutr0n <harikp2002@gmail.com>
|
Addressed the review: moved the DOCX callback regression tests into process/test.rs, declared the module from process/mod.rs, and verified all convert_service tests pass. Mr-Neutr0n@8d40a1f |
Problem
process_messageonly recognized keys ending in lowercase.docxwhen deciding whether to send the completion or failure callback. The conversion parser accepts extensions case-insensitively, so.DOCXuploads could convert successfully while the client received no status update.Fix
Use the same case-insensitive extension behavior for callback routing and add focused tests for mixed-case and trailing-extension cases.
Verification
cargo test -p convert_service docx_detection --offlinecargo fmt --all -- --checkNo existing open issue or pull request covers this callback mismatch.