Skip to content

fix(convert): notify DOCX uploads with mixed-case extensions - #5594

Merged
whutchinson98 merged 2 commits into
macro-inc:mainfrom
Mr-Neutr0n:fix/docx-callback-case
Aug 13, 2026
Merged

fix(convert): notify DOCX uploads with mixed-case extensions#5594
whutchinson98 merged 2 commits into
macro-inc:mainfrom
Mr-Neutr0n:fix/docx-callback-case

Conversation

@Mr-Neutr0n

@Mr-Neutr0n Mr-Neutr0n commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Problem

process_message only recognized keys ending in lowercase .docx when deciding whether to send the completion or failure callback. The conversion parser accepts extensions case-insensitively, so .DOCX uploads could convert successfully while the client received no status update.

Fix

Use the same case-insensitive extension behavior for callback routing and add focused tests for mixed-case and trailing-extension cases.

Verification

  • cargo test -p convert_service docx_detection --offline
  • cargo fmt --all -- --check

No existing open issue or pull request covers this callback mismatch.

Signed-off-by: Mr-Neutr0n <harikp2002@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e9e5832-6631-404f-9e96-55742fd34bf0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@services/convert_service/src/process/convert.rs`:
- Around line 133-148: Move the inline test module containing
docx_detection_accepts_mixed_case_extensions and
docx_detection_requires_the_final_extension from convert.rs into
process/test.rs. Replace the inline body in convert.rs with the separate-module
declaration #[cfg(test)] mod test;, preserving the existing imports and test
assertions.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 999f1cdd-c1f3-4531-b619-c587407092cd

📥 Commits

Reviewing files that changed from the base of the PR and between 412bc88 and 7fc6bd4.

📒 Files selected for processing (1)
  • services/convert_service/src/process/convert.rs

Comment thread services/convert_service/src/process/convert.rs Outdated

@whutchinson98 whutchinson98 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mr-Neutr0n thanks for your contribution!

Just a minor nit then we are good to merge

Comment thread services/convert_service/src/process/convert.rs Outdated
Signed-off-by: Mr-Neutr0n <harikp2002@gmail.com>
@Mr-Neutr0n

Copy link
Copy Markdown
Contributor Author

Addressed the review: moved the DOCX callback regression tests into process/test.rs, declared the module from process/mod.rs, and verified all convert_service tests pass. Mr-Neutr0n@8d40a1f

@whutchinson98
whutchinson98 merged commit 43eb0db into macro-inc:main Aug 13, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants