Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrcpy: update to version 2.2, fix build on 10.10 #21191

Merged
merged 1 commit into from
Nov 11, 2023
Merged

scrcpy: update to version 2.2, fix build on 10.10 #21191

merged 1 commit into from
Nov 11, 2023

Conversation

aprovera
Copy link
Contributor

@aprovera aprovera commented Nov 1, 2023

  • update to version 2.2
  • change clang blacklist from 700 to 701 to support 10.10

Closes: https://trac.macports.org/ticket/68420

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.6 18G9323 x86_64
Xcode 11.3.1 11C505

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@aprovera
scrcpy: update to version 2.2, fix build on 10.10
a460241 
* update to version 2.2
* change clang blacklist from 700 to 701 to support 10.10

Closes: https://trac.macports.org/ticket/68420
@macportsbot
Copy link

Notifying maintainers:
@MarcelBochtler for port scrcpy.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Nov 1, 2023
MarcelBochtler
MarcelBochtler approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@MarcelBochtler MarcelBochtler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aprovera.
Changes look good to me.
Tested on:
macOS 14.0 23A339 arm64
Xcode 14.1 14B47b

And Android 14.

@aprovera aprovera marked this pull request as draft November 5, 2023 23:10
@aprovera
Copy link
Contributor Author

aprovera commented Nov 5, 2023 •
edited
Loading

Temporarily converted to draft as it looks like v2.2.1 may come out shortly.

@aprovera
Copy link
Contributor Author

aprovera commented Nov 9, 2023 •
edited
Loading

No sign of 2.2.1 yet, so if @MarcelBochtler agrees maybe we can proceed with this for the time being after all.

@aprovera aprovera marked this pull request as ready for review November 9, 2023 13:21
@reneeotten reneeotten merged commit 7eefe11 into macports:master Nov 11, 2023
3 checks passed
@aprovera aprovera deleted the scrcpy-2.2 branch November 12, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelBochtler MarcelBochtler MarcelBochtler approved these changes

Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port type: update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aprovera @macportsbot @MarcelBochtler @reneeotten