Fix for CreateTable not always adding missing columns #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would happen when a previous INSERT/UPDATE/DELETE statement query modified rows. The existing code was incorrectly attempting to check whether a CREATE IF NOT EXISTS statement did anything. https://www.sqlite.org/c3ref/changes.html
| MigrateTable(map); | ||
| } | ||
| // add columns if necessary | ||
| MigrateTable(map); |
There was a problem hiding this comment.
Yes, it's an empty for loop. In fact, if you read the old comment, this was known to be happening when they didn't want it to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would happen when a previous INSERT/UPDATE/DELETE statement query modified rows. The existing code was incorrectly attempting to check whether a CREATE IF NOT EXISTS statement did anything.
https://www.sqlite.org/c3ref/changes.html