Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade R# to 2021.3 #188

Merged
merged 13 commits into from
Dec 8, 2021
Merged

Upgrade R# to 2021.3 #188

merged 13 commits into from
Dec 8, 2021

Conversation

robertcoltheart
Copy link
Member

@robertcoltheart robertcoltheart commented Oct 21, 2021

Sigh another set of wonderful breaking changes from the geniuses at JB.

@robertcoltheart robertcoltheart marked this pull request as ready for review December 8, 2021 14:57
@robertcoltheart robertcoltheart merged commit e9627da into master Dec 8, 2021
@robertcoltheart robertcoltheart deleted the feature/version-2021-3 branch December 8, 2021 15:05
@mikeblakeuk
Copy link

mikeblakeuk commented Dec 8, 2021

Using VS2022 17.0.2 with R# 2022.3 windows 10

image

We do have "some" Behavior tests so don't want to migrate them yet.

Note, if you comment out //Behaves_like it appears to work.

Do you have a migration plan for Behavior?


System.InvalidCastException: Unable to cast object of type 'Machine.Specifications.Runner.ReSharper.Elements.MspecContextSpecificationTestElement' to type 'Machine.Specifications.Runner.ReSharper.Elements.MspecBehaviorSpecificationTestElement'.
   at Machine.Specifications.Runner.ReSharper.UnitTestElementFactory.GetOrCreateBehaviorSpecification(MspecBehaviorTestElement behavior, String fieldName, String ignoreReason)
   at Machine.Specifications.Runner.ReSharper.MspecTestMetadataExplorer.ExploreBehavior(MspecContextTestElement contextElement, IFieldInfo field)
   at Machine.Specifications.Runner.ReSharper.MspecTestMetadataExplorer.ExploreContext(ITypeInfo type)
   at Machine.Specifications.Runner.ReSharper.MspecTestMetadataExplorer.ExploreAssembly(IMetadataAssembly assembly, CancellationToken token)
   at JetBrains.ReSharper.UnitTestFramework.Exploration.Artifacts.MetadataElementsSource.ExploreProject(IProject project, FileSystemPath outputPath, MetadataLoader loader, ILogger logger, CancellationToken cancellationToken, Action`1 exploreAssembly)
   at Machine.Specifications.Runner.ReSharper.MspecTestExplorerFromMetadata.ProcessProject(MetadataLoader loader, IUnitTestElementObserver observer, CancellationToken token)
   at JetBrains.ReSharper.UnitTestFramework.Exploration.Artifacts.UnitTestExplorerFrom.Metadata.ProcessProjectCore(IUnitTestElementObserver observer, CancellationToken token)
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at JetBrains.ReSharper.UnitTestFramework.Exploration.Artifacts.UnitTestExplorerFrom.DotNetArtifacts.Async.<ProcessArtifact>d__2.MoveNext()

@robertcoltheart
Copy link
Member Author

Will take a look.

Behaviors will be supported for the time being, probably beyond v2. For v3 I'm planning on introducing Examples which will (possibly) deprecate behaviors, see machine/machine.specifications#141

@mikeblakeuk
Copy link

Hi,

Any news on this? Thanks

@robertcoltheart
Copy link
Member Author

Unfortunately it isn't a simple fix, I have a branch in progress but need more time to finish it.

@mikeblakeuk
Copy link

OK. Thank you for looking. It is blocking our vs2022 / rider upgrade.

@mikeblakeuk
Copy link

Tracked here machine/machine.specifications#459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants