Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: hyperkit go bindings. #189

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dlorenc
Copy link
Collaborator

@dlorenc dlorenc commented Jul 10, 2017

This isn't fully ready yet, but I was able to get minikube booting with it.

@dlorenc
Copy link
Collaborator Author

dlorenc commented Jul 10, 2017

Ref #168

@dlorenc dlorenc force-pushed the hyperkit branch 3 times, most recently from b9b9a88 to 0a32047 Compare July 13, 2017 01:34
@dlorenc
Copy link
Collaborator Author

dlorenc commented Jul 13, 2017

OK, @zchee this should be ready for a look. I split the vendor changes into another commit to make it easier to review.

@zchee
Copy link
Member

zchee commented Jul 13, 2017

@dlorenc Woa, I’ll check it asap.
Thanks great work!!

@zchee
Copy link
Member

zchee commented Jul 13, 2017

/cc @praveenkumar @dalehamel

@praveenkumar
Copy link
Collaborator

@dlorenc Great, I will test it out and let you know.

- package: github.com/jceel/lib9p
version: 7be3e0b914fbb2d2ecfe2984d02bacfd8e762eae
- package: github.com/zchee/go-vmnet
- package: github.com/moby/hyperkit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put version v0.20170425 so that each iteration shouldn't get from master.

- package: github.com/moby/hyperkit
  version: v0.20170425

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually need 62fb993cc65090d3efe29e9b1ed871b017eeaa4d, it contains a PR I submitted yesterday to add support for qcow and sparsebundle disks. What's the best way to pin to that in glide?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlorenc Then you just put this hash as version. Below should work.

- package: github.com/moby/hyperkit
  version: 62fb993cc65090d3efe29e9b1ed871b017eeaa4d

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@dlorenc
Copy link
Collaborator Author

dlorenc commented Jul 20, 2017

@zchee have you had a chance to look here?

@zchee
Copy link
Member

zchee commented Jul 20, 2017

@dlorenc Ah, sorry late.
I joined @mercari yesterday. So, little busy.
but I'll check asap.

@dlorenc
Copy link
Collaborator Author

dlorenc commented Jul 20, 2017

I joined @mercari yesterday. So, little busy.

Congrats!

@zchee
Copy link
Member

zchee commented Jul 20, 2017

@dlorenc :D

@zchee
Copy link
Member

zchee commented Jul 25, 2017

@dlorenc I'll check today

@praveenkumar
Copy link
Collaborator

@dlorenc @zchee Is there anything we are waiting for? This PR still in WIP.
@dlorenc There is some conflict, please rebase.

@praveenkumar
Copy link
Collaborator

@dlorenc I compiled from your PR and tried to provision minishift looks like networking doesn't go well and VM not able to get the IP. Another thing I noticed that now process id associate to hyperkit.

(minishift) DBG | Not there yet 60/60, error: IP not found for MAC 2:51:8:22:87:a6 in DHCP leases
- FAIL E0830 12:02:04.074449    1724 start.go:344] Error starting the VM: Error creating the VM. Error creating machine: Error in driver during machine creation: Machine didn't return an IP after 120 seconds, aborting. Retrying.
Found binary path at /usr/local/bin/docker-machine-driver-xhyve
Launching plugin server for driver xhyve
Plugin server listening at address 127.0.0.1:49376
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
(minishift) Calling .GetState
FAIL E0830 12:02:04.104117    1724 start.go:344] Error starting the VM: Error getting the state for host: Unable to find 'xhyve' process by PID: 1781. Retrying.
Found binary path at /usr/local/bin/docker-machine-driver-xhyve
Launching plugin server for driver xhyve
\ Plugin server listening at address 127.0.0.1:49380
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
(minishift) Calling .GetState
FAIL E0830 12:02:04.125552    1724 start.go:344] Error starting the VM: Error getting the state for host: Unable to find 'xhyve' process by PID: 1781. Retrying.
Error starting the VM: Error creating the VM. Error creating machine: Error in driver during machine creation: Machine didn't return an IP after 120 seconds, aborting
Error getting the state for host: Unable to find 'xhyve' process by PID: 1781
Error getting the state for host: Unable to find 'xhyve' process by PID: 1781

✘-INT ~/work/github/go_practice/bin 
12:02 $ ps aux | grep xhyve
prkumar          1844   0.0  0.0  2432804   1892 s002  S+   12:02PM   0:00.00 grep xhyve

✔ ~/work/github/go_practice/bin 
12:02 $ ps aux | grep hyperkit
root             1781   0.1  0.1 10855132  10612 s002  S    12:00PM   0:00.39 /Applications/Docker.app/Contents/MacOS/com.docker.hyperkit -A -u -F /Users/prkumar/.minishift/machines/minishift/hyperkit.pid -c 2 -m 8192M -s 0:0,hostbridge -s 31,lpc -s 1:0,virtio-vpnkit,path=/Users/prkumar/Library/Containers/com.docker.docker/Data/s50 -s 2:0,virtio-net -U F4BB3F79-AB4E-4708-95CA-E32FBFCDEFD3 -s 3:0,ahci-hd,/dev/rdisk2 -s 4,virtio-rnd -l com1,autopty=/Users/prkumar/.minishift/machines/minishift/tty,log=/Users/prkumar/.minishift/machines/minishift/console-ring -f kexec,/Users/prkumar/.minishift/machines/minishift/vmlinuz64,/Users/prkumar/.minishift/machines/minishift/initrd.img,earlyprintk=serial loglevel=3 user=docker console=ttyS0 console=tty0 noembed nomodeset norestore waitusb=10:LABEL=boot2docker-data base
prkumar          1857   0.0  0.0  2432804   1900 s002  S+   12:02PM   0:00.00 grep hyperkit

@praveenkumar
Copy link
Collaborator

@dlorenc @zchee ping !

@zchee
Copy link
Member

zchee commented Sep 14, 2017

@praveenkumar Ah, sorry. I"ll reply tomorrow.

@periklis
Copy link

@dlorenc & @zchee can some of you elaborate if this changeset removes the need to use sudo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants