Enum instead of string and C++14 support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Enum, in addition don't use python liek structure binding as this isn't c++14 compliant. Given this was only place which c++14 doesn't like it is better to use something simpler.
…ariables whihc are part of class (this is waste) now we fill xsec norm direclty from yaml. This should make mainanace and code clarity much better. I am thinking to make similiar stucture for splines in the near future.
… more mainainteable, but also is better memroy wise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Instead of doing string comaprison whether param is spline or norm let's use enum, param types always have to be defined by MaCh3 core, I can't imagine expeirent sepcyfic types, in future types might be expadnaed, using enums helps to mainaint good code.
Also not use python like structure binding, as this causes problem in c++14. Given still many poep have root with c++14 and this was easy change I did this. MaCh3 natively should use c++14 but if we can easily mianaint c++14 then why not.
This was the issue
Setting XsecNorm4 was a mess. First we filled variables like modes, only later to save it to XsecNomr4. Now rather than have many artifialc variabels we store only XsecNorm4. This means that potetnail expansion to XsecNorms5 will be easier as everythig is handled
GetXsecNormrather than many bits in different places.left old, right new