Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bag of tricks I learned from Luke #74

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Conversation

KSkwarczynski
Copy link
Member

@KSkwarczynski KSkwarczynski commented Jul 11, 2024

Pull request description:

Introduce small changes t ocmake due to changes in ROOT

Changes or fixes:

  • Minuit is now default, make cmake work with old as well as new ROOT cmake
  • move most of dependencies to separte cmake file. For example incuions of NuOsillator will requeir modifyng MaCh3 feature list etc. Having in seperate file means main cmake is less clunky
  • Add cmkae utils to reduce copy pasting
  • As always documeantions
  • docuemantion as always
  • XsecNorm is now struct not class
  • Add new fucniton GetXsecNorm, becasue SetupNormPars and GetNormParsFromDetID were like 99% the same. There are weird issues rleated with copying so we have to inilaise XsecNorm whenever we call GetNormParsFromDetID , should be fixed in the future. But for the the time being just reduce copy pasting.
  • Remove some stupid code which could cahnge your prefit value...
  • Lots of passing of vectors string by reference to ratherr than copying to make thigns safer and better perofmance wise
  • Intorduce Syst type enums to avoid copy pasting

Examples:

Oscillator will be fully indepednent from MaCh3 project. Expand logger so we can in fancy way convert messages from osciallor. This is to ensure cosnitnet messages but also in case there are more exteranl proejcts, in T2K we use psyche, NIWG RW etc. having prinouts [NIWG], [NuOsc] or [psyche] are helpfull. Sadly code to make this is bit convoluted. But I think it should be fine. Here example
Logger

@KSkwarczynski KSkwarczynski self-assigned this Jul 11, 2024
@KSkwarczynski KSkwarczynski linked an issue Jul 12, 2024 that may be closed by this pull request
@KSkwarczynski KSkwarczynski merged commit a40f944 into develop Jul 12, 2024
3 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_BagofTricks branch July 12, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define Covaraince Enum to avoid copy pasting
1 participant