Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Garbage #183

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Remove Garbage #183

merged 3 commits into from
Oct 25, 2024

Conversation

KSkwarczynski
Copy link
Member

@KSkwarczynski KSkwarczynski commented Oct 24, 2024 •
edited
Loading

Pull request description

WARNING, this will break DUNE!
Changes here are not backward compatibilte

Changes or fixes

  • We no longer need special treatment for cov osc in fitter base. Now cov osc should be added same way as any other systematics
  • Stop with terrbile hardcdoing of fixing baseline etc
  • stop using const char, we should do this long time ago
  • Remove many getter in cov osc, we should enforce using new more gnereir getters

Examples

@KSkwarczynski
stop wiht const char nonsense, stop with special treatment of cov osc…
4ea0a75 
… in fitter base and lastly furhter unfiy fucntions in cov osc
@KSkwarczynski
minor
d722144
@KSkwarczynski KSkwarczynski self-assigned this Oct 24, 2024
@github-actions GitHub Actions
Copy link

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions bot added MCMC MCMC related Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples labels Oct 24, 2024
This was linked to issues Oct 24, 2024
Stop with const char* in covariance #164
Closed
Stop with special treatment of osc cov in FitterBase #162
Closed
EdAtkin
EdAtkin approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@EdAtkin EdAtkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, you even kept the python version up to date!

dbarrow257
dbarrow257 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@dbarrow257 dbarrow257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no comments - already tested on DUNE and found no problems.

@dbarrow257 dbarrow257 merged commit 210ae41 into develop Oct 25, 2024
10 checks passed
@dbarrow257 dbarrow257 deleted the feature_RemoveGarbage branch October 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarrow257 dbarrow257 dbarrow257 approved these changes

@EdAtkin EdAtkin EdAtkin approved these changes

@henry-wallace-phys henry-wallace-phys Awaiting requested review from henry-wallace-phys henry-wallace-phys is a code owner

@ewanwm ewanwm Awaiting requested review from ewanwm ewanwm is a code owner

Assignees

@KSkwarczynski KSkwarczynski

Labels
MCMC MCMC related Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop with const char* in covariance Stop with special treatment of osc cov in FitterBase
3 participants
@KSkwarczynski @dbarrow257 @EdAtkin