Use CFApp /api/v1/commitfest/active endpoint to find CFIds #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need to be applied after the corresponding CFApp commit that exposes the API.
This is only lightly tested. I wanted to get something out since I've pushed a PR for the CFApp side of this.
I did quite a bit more API-based work but have yet to get a running instance using the scraping against a dev CFApp in place. Assuming the replaced code worked switching from the "+1" computation of a CF to getting three explicit CF IDs from the API should not impact any later code in the processing stream.
I made an educated guess on the rebuild/build_page code. Putting out links to potentially non-existent URLs (the In Progress one will not be active for like half the year) isn't ideal but given the user base and non-primary nature of this UI the expedient solution seems reasonable.