Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Redis host and port arguments #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benlong
Copy link

@benlong benlong commented Jan 27, 2012

Updated server.js to accept --redisport and --redishost arguments.

Values are passed to listen(), and normalized to defaults. From here forwarded along through the application.

A minor 'refactorish' change: Events.client is no longer created inline. Instead publish inits channel which inits event with proper redis information.

We're using this in production today. I'm interested in feedback/drawbacks of the implementation. I have another patch that allows the use of Redis.namespace for namespaced redis instances.

@felipecsl
Copy link

+1 I need this to run juggernaut in rails test environment, which connects to redis in a different port
👍

@snovotny
Copy link

+1 this patch works well for connecting to a different host redis is running on

@redterror
Copy link

+1

4 similar comments
@kebot
Copy link

kebot commented Aug 14, 2012

+1

@barttenbrinke
Copy link

+1

@Narnach
Copy link

Narnach commented Mar 20, 2013

+1

@codenamev
Copy link

+1

@alexandre-mbm
Copy link

👍 I was seeing exactly this here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants